https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. The second patch "Add tests" adds a change to the module, is that expected? 2. You are modifying a test that is not (at first glance) directly related to your changes, why? @@ -2094,7 +2094,7 @@ subtest 'AddReturn + CumulativeRestrictionPeriods' => sub { is( scalar(@$debarments), 1 ); $expected_expiration = output_pref( { - dt => $now->clone->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ), + dt => $now->clone->add( days => ( 10 - 1 ) * 2 ), 3. # there's no overdue on the item but borrower had been previously debarred - } elsif ( $issue->date_due and $patron->debarred ) { + if ( $patron->debarred ) { Comment and code not kept in sync. Please clarify. -- You are receiving this mail because: You are watching all bug changes.