https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27066 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #10)
tl;dr I don't think 'before' or 'after' hooks should directly affect the data of the action.
We probably want 'before' and 'after' hooks.. and maybe even an 'around'.
Generally, a 'before' hook is for triggering actions prior to store (but not affecting the data for the store itself).. 'after' is for triggering actions after the store (like triggering zebraqueue.. again, it shouldn't affect the data of the store itself) and an around wraps the store and returns the updated data for the store to then act upon.
At least, that's my vague understanding of 'before', 'after', 'around' in other frameworks?
That's an interesting point. I hadn't thought of that... -- You are receiving this mail because: You are watching all bug changes.