https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #18)
4. I do not think update_category should be a Koha::Patrons method, to me it belongs to Koha::Patron Hmm, I don't know that it does enough to a single patron to be a method, the utility is acting on many at once. I can move if you feel strongly
The method iterates on the patrons, so to me it should be replaced with: while ( my $p = $patrons->next ) { $p->update_category($params); } and the method moved. As the signoff comes from Jesse I would prefer to wait for another QA point of view anyway. -- You are receiving this mail because: You are watching all bug changes.