https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Julian Maurice from comment #15)
There is at least 3 places where IsAvailableForItemLevelRequest is called and CanItemBeReserved is not:
* opac/opac-ISBDdetail.pl * opac/opac-MARCdetail.pl * opac/opac-detail.pl
(side note: it's the same code in those 3 scripts and it's used to set a template variable used only in opac-detail-sidebar.inc; should be moved into a TT plugin ?)
Indeed, I just added those checks on bug 34886
Removing checks from IsAvailableForItemLevelRequest means that those checks won't be done in these places.
Instead, do you think it's possible to call IsAvailableForItemLevelRequest from CanItemBeReserved ? (and remove calls to IsAvailableForItemLevelRequest whenever CanItemBeReserved is called)
See comment 1 - I think that's the ultimate goal Would you be willing to accept a smaller change in those scripts for now? $can_holds_be_placed = IsAvailableForItemLevelRequest($item, $patron, undef) && CanItemBeReserved($patron, $item, undef); -- You are receiving this mail because: You are watching all bug changes.