https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42032 Bug ID: 42032 Summary: Add diff support to AUTHORITIES action logs Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Blocks: 37940 The action logging in C4/AuthoritiesMarc.pm for authority record changes currently passes unstructured text (or the literal string 'authority') to logaction(). No structured diff is generated in the action_logs.diff column. Affected calls in C4/AuthoritiesMarc.pm: - AUTHORITIES/ADD (~line 688): logaction( "AUTHORITIES", "ADD", $authid, "authority" ) - AUTHORITIES/DELETE (~line 755): logaction( "AUTHORITIES", "DELETE", $authid, "authority" ) - AUTHORITIES/MODIFY (~line 792): logaction( "AUTHORITIES", "MODIFY", $authid, "authority BEFORE=>" . $oldrecord->as_formatted ) This bug covers updating these calls to pass structured data. A Koha::Authority object (or its unblessed hashref) should be passed as $infos and $original so that the structured diff mechanism can generate a proper before/after comparison. The MODIFY case already captures the old record; this should be passed as $original in the new structured format. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940 [Bug 37940] [OMNIBUS] All modification logged via action logs should include original to create JSON diff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.