https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- (In reply to wainuiwitikapark from comment #7)
(In reply to Lucas Gass from comment #6)
Looking good!
One area that is a bit odd looking now is OPAC purchase suggestions. Now there is an h1 and and h2 with very similar text. Can this be fixed?
Hi Lucas! Thanks for your comment! Yes that is definitely very redundant. However, the aim of this bug was to just ensure that there is one <h1> heading on each page of the OPAC. Then the Bug 27740 ensures the structure and hierarchy of the headings under <h1> are correct. Neither of those are specifically dealing with redundancy of headings and/or whether or not headings under <h1> are actually headings (i.e. there are currently some errors and alerts that are <h> tags that shouldn't actually be headings). Therefore, I think if you want to make a follow up patch about this particular issue, that depends on this Bug 27610 and Bug 27740, that would probably be the best way to go. Great spotting though and appreciate the feedback!
Hey again, on second thought, I'll just make a new bug myself that deals with things like redundancy of page titles and then I will also make another bug about things that shouldn't be headings. Watch this space for the new bugs :) I'll make them soon. -- You are receiving this mail because: You are watching all bug changes.