6 Nov
2019
6 Nov
'19
1:30 p.m.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Julian Maurice from comment #17)
It would be great to have Jonathan's opinion as he wrote the patch for bug 18539
Looking back, I think that the biggest problem was using ->find in parameter hashes like { var1 => KO->find, var2 => etc }. Here we have list context and if there was no result, we were returning an empty list causing a parameter/value shift. This comes from: return unless $result; Since your patch does not return empty list, we would not suffer from that. -- You are receiving this mail because: You are watching all bug changes.