https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #133 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Thanks Matt! One follow-up per point: 1) Handle HoldsAutoFill errors on check-in - the item is already returned, so a HoldNotFound/ItemCheckedOut from confirm_hold now becomes a 'hold_auto_fill_failed' warning message on the checkin (with the error_code) instead of a 500. The holds queue and bundle logic still run. 2) Make checkin follow-up actions atomic - confirm_hold, cancel_hold, confirm_transfer, cancel_transfer, confirm_recall and replace_wrong_transfer run inside a transaction. Tests make the transfer step die and check the hold is untouched. 3) Mark the row of the resolved return claim - the modal emits the claim_id and the matching row is updated (Cypress test with two claimed items). 4) Restore the time and past-only return date - the picker takes a time and blocks future dates as the legacy page did. The API now takes a date-time and rejects future dates with 400 'return_date_in_future'. 5) The X-Koha-Module-Policy header is gone: the series was re-uploaded with the policy returned as an optional, well-defined 'policy' attribute of the error object instead (see the previous comment). 6) Fix the Location header of checkin actions - it is now the action path (e.g. /api/v1/checkins/1/hold_confirmation), without the action token query string. Back to Signed Off for your review. -- You are receiving this mail because: You are watching all bug changes.