https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34433 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153993&action=edit Bug 34433: 'Custom cover image' in lightbox is untranslatable In the staff interface, when viewing a custom cover image in the lightbox, at the bottom, it says 'Custom cover image'. This string is not translatable. The string is missing the _() i18n function. This patch also corrects the "Coce image from Amazon.com" which was missing the correct i18n function too. If necessary, import the MARC records attached to this bug to use in testing. 1. Enable CustomCoverImages 1.1. Go to Administration > System preferences 1.2. Search for CustomCoverImages 1.3. Select "Show" in CustomCoverImages 1.4. Set CustomCoverImagesURL to {956$u} 1.5. Click "Save all Enhanced content preferences" 2. Install a new language 2.1. gulp po:update --lang fr-CA 2.2. Search for "Custom cover image" and "Coce image from Amazon.com" in fr-CA-staff-prog.po file, make sure it is translated 2.3. Install translations ./misc/translator/translate install fr-CA 2.4. In the staff interface, go to Administration > System preferences 2.5. Search for language 2.6. Check the box next to the newly installed language 2.7. Click "Save all I18N/L10N preferences" 3. View the image in the lightbox in the staff interface 3.1. If using the attached records, search the catalog in the staff interface for "As you like it"; If not using the file, add an image URL in 956$u, or finagle something with CustomCoverImagesURL 3.2. Click on the title to view the detailed record 3.3. Click on the image to view it in the lightbox Test the lightbox in the default English translation and in your newly-translated language. In both cases the caption in the lightbox footer should be correct. -- You are receiving this mail because: You are watching all bug changes.