https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39828 Bug ID: 39828 Summary: QuickAdd skips fields from PatronQuickAddFields in some cases Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: slavashishkin@gmail.com Reporter: slavashishkin@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When using PatronQuickAddFields to add fields to the Quick Add form, fields that exist in the main form but contain multiple input elements (especially hidden/disabled ones) may be silently skipped during QuickAdd form generation. Example: "userid" field exists in the full patron form (entryform) as:
<li> <label for="userid">Username:</label> <input type="text" id="userid" name="userid" ...> <input type="text" disabled="disabled" style="display:none" ...> </li>
The current JavaScript logic to detect and clone these fields uses:
let orig_input_id = orig_li.children("input,textarea,select").last().attr("id");
In this example, .last() selects the hidden disabled input without an id → orig_input_id becomes undefined → and the field is not cloned into QuickAdd form. Result: userid is missing from Quick Add even though it's included in PatronQuickAddFields. Steps to reproduce: 1. Add userid (or any other field that matches above structure) to PatronQuickAddFields. 2. Open the Add Patron form and use Quick Add. 3. Observe → the field is missing. -- You are receiving this mail because: You are watching all bug changes.