https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41521 --- Comment #148 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #23)
Those patches fix most of the issues.
Remaining ones:
not ok 455 - Koha/ExternalContent/OverDrive.pm has syntax warnings. # Failed test 'Koha/ExternalContent/OverDrive.pm has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643.
not ok 2266 - opac/external/overdrive/auth.pl has syntax warnings. # Failed test 'opac/external/overdrive/auth.pl has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643.
not ok 2356 - opac/svc/overdrive has syntax warnings. # Failed test 'opac/svc/overdrive has syntax warnings.' # at xt/pl_valid.t line 63. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. # Possible precedence issue with control flow operator (die) at /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643.
Test plan: Startup ktd using trixie's image export DB_IMAGE=mariadb:latest; export KOHA_IMAGE=main-trixie; ktd pull && ktd down && ktd --selenium --es7 up Run prove xt/pl_valid.t
Moved to bug 41521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 [Bug 41521] WebService::ILS::OverDrive not passing pl_valid -- You are receiving this mail because: You are watching all bug changes.