https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42621 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |blawlor@clamsnet.org --- Comment #17 from Brendan Lawlor <blawlor@clamsnet.org> --- This works quite nicely as described. I'm only failing QA because the qa script picks up a tidy issue: [FAIL] t/db_dependent/Koha/Reports.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/Koha/Reports.t` Also, I'm not sure if this is an issue with the atomic update, but if you run updatedatabase twice you get an error: DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_42621.pl [19:29:08]: Bug 42621 - Extend report limitations by library to use library groups ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'LimitReportsBy' for key 'PRIMARY' at /kohadevbox/koha/C4/Installer.pm line 818 Other than that this is looking good. Nice work! -- You are receiving this mail because: You are watching all bug changes.