https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com Status|Failed QA |In Discussion --- Comment #8 from Charles Farmer <charles.farmer@inlibro.com> --- Despite the 'uninitialized value in join...' , I feel like $unitcounttotal shouldn't take any _numerical_ values. The concept of chargeunits stops making sense once you arbritraly charge the overduefinescap after X given days, which is exactly what maxfinesdays does. It's not bothered by closing hours, nor does it care about grace periods, it bluntly maxes out the fine. This seems like a reason not to consider any information derived from $issuing_rule->lengthunit. Now, as I hinted at the beginning, I'm definitely open to initializing $unitcounttotal. Since its only use is to be concanated with other fields before being outputed to a file, it could make sense to inform the fines report's reader that maxfinesdays was applied. Is this approach sound in your opinion? -- You are receiving this mail because: You are watching all bug changes.