https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39188 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179302|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 180436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180436&action=edit Bug 39188: Fix ESLint by Updating "globals" node package According to the main dev of ESLint, we should add it to devDependencies because we are the ones calling globals from eslint.config.mjs: https://github.com/eslint/eslint/issues/19209#issuecomment-2518452107 Test plan: 1. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue 2. TypeError: Key "languageOptions": Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace 3. :( 4. Apply patch 5. sudo yarn install --modules-folder /kohadevbox/node_modules 6. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue 7. eslint output a report about the issues found in the file 8. signoff :D Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.