http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #6)
Martin,
Actually the 3 patches (from bug 14246 and 14247) could have been attached to this bug report. No need to open 3 bug reports for 1 enh :)
I agree. However, 14246 and 14247 are passable in my opinion. This one is not.
I have some remarks concerning this patch: 1/ You add changes to a module file, in most of the cases, you have to provide tests to make sure there won't be regression later. Here you have to test C4::NewsChannels::get_opac_news, have a look at t/db_dependent/NewsChannels.t
There are no tests added. Suggestion: test to see that the title, firstname, and surname keys exist in at least the first row of results. This is why I'm leaving it failed QA. -- You are receiving this mail because: You are watching all bug changes.