http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Bug ID: 11983 Summary: code to select patrons to purge needs to be centralized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org The patch for bug 11352 introduces a routine in tools/cleanborrowers.pl called skip_borrowers_with_nonzero_balance. This filters out patrons who have active fine balances so that the patron purge does not inadvertently delete/trash them. This logic should be put in a central routine, e.g., perhaps in GetBorrowersToExpunge(). At present, misc/cronjobs/delete_patrons.pl also has logic to not purge patrons with fine balances, but it implements it differently. Having two different implementations of the same functionality is not great, but I (in my role as 3.16 RM) allowed it because of the potential for data loss that the patch for bug 11352 fixed. However, this situation should not be allowed to persist. -- You are receiving this mail because: You are watching all bug changes.