https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43956 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I have replaced the patch with a revised version. Nothing has been tested yet, so I have squashed the change into the single patch rather than adding a follow-up. What changed: rounding mode and number of decimal places are now optional settings of the Koha::Number::Price object instead of parameters on each method: Koha::Number::Price->new( $value, { mode => 'half_up', digits => 3 } ) Anything not set falls back to half_even and 2 decimal places. round(), format() and format_for_editing() all use the same settings, so they cannot disagree. This gives the follow-up bugs one place to supply the currency and rounding preferences (bug 43957). The tests now also check, for every rounding mode, that format() and format_for_editing() give the same value as round(). -- You are receiving this mail because: You are watching all bug changes.