http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #28 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 23523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23523&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. Test Plan: 1) Apply this patch 2) Verify superlibrarian behavior remains unchanged Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.