https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36668 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 165325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165325&action=edit Bug 36668: Excessive whitespace/newlines in circulation rules editor may cause slow loads with large rules sets Simply put we have a lot of SET lines and such in our circ rules editor template. For large rule sets all the newlines add up and can balloon the rendered html size to many megabytes! We should add a newline chomper to these lines. 1) Generate a large number of circ rules with the following perl script use Koha::CirculationRules; use Koha::Patron::Categories; use Koha::ItemTypes; use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new(); $builder->build( { source => 'Category' } ) for 0 .. 80; $builder->build( { source => 'Itemtype' } ) for 0 .. 80; C4::Context->dbh->do(" INSERT IGNORE INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) SELECT NULL, categories.categorycode, itemtypes.itemtype, 'issuelength', 5 FROM categories JOIN itemtypes;" ); 2) Open the network debugging on your web browser 3) Load smart-rules.pl 4) Notice the size of the file 5) Apply this patch 6) Restart all the things! 7) Reload smart-rules.pl 8) Note the file size has been drastically reduced! -- You are receiving this mail because: You are watching all bug changes.