https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #3)
I don't like the use of 'id'. We have borrowernumber and userid on this object. And we have patron_id for the REST API.
It might be obvious for you and me, but for new developers it can be very confusing I think.
I always felt like ->id (being the defined PRIMARY KEY) was a good practice as, in general, we end up using `$patron->id` which reads as 'the patron id' (at least in my brain). In this case, the comparison is with a 'borrowernumber' attribute, so I'd say I will change it to `$patron->borrowernumber` as it reads well. -- You are receiving this mail because: You are watching all bug changes.