https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40682 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |ILL |and plumbing | CC| |lisette@bywatersolutions.co | |m, | |pedro.amorim@openfifth.co.u | |k, tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I would like to add that the method itself does: * log status changes * deal with status_alias undefinition This means those features will only be used if ->status is used exclusively when changing statuses. This means an author using: ```perl $req->set( { status => 'NEW_STATUS', due_date => dt_from_string() } )->store(); ``` won't get the expected results. We need to either: * Document statuses should never be done using ->set or ->update (including the resultset method) * Move all this to the store() level I also noticed the trick for nullifying the status_alias is also a consequence of how accessors are used in this module. This all needs a rethink. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.