https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Bug ID: 18880 Summary: Regression breaks local authentication fallback for all external authentications Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: oliver.bock@aei.mpg.de QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Created attachment 64719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64719&action=edit Proposed patch A regression in commit cfc484b17 / bug #18314 breaks the local authentication fallback for all external authentications like LDAP, CAS and Shibboleth. The severity is critical for us as we, while using LDAP authentication, use the self-service checkout which requires a local user account. Also non-LDAP staff can't log into the staff pages anymore. The regression itself is a logical error as "@return = (0)" is considered to be "false" when checked with "unless". That's wrong as "unless" tests the number of elements in a list. Thus the "falsy" condition has to established with "@return = ()" instead. Please find attached a proposed patch against "17.05.x". Also, please make sure the fallback workflow gets test coverage. Thanks, Oliver -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.