https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40445 --- Comment #123 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193136&action=edit Bug 40445: (follow-up) Allow cashup with non-cash transactions Previously, the "Record cashup" buttons on both the register and registers pages were disabled when there were zero CASH/SIP00 transactions, even if other payment types (Card, etc.) had transactions. This was incorrect - cashup should be allowed as long as there are ANY transactions, regardless of payment type. Staff still need to record cashups even when all transactions were Card or other non-cash payment methods. Changes: - register.tt: Check total_transactions instead of total_bankable to determine if cashup button should be enabled - registers.tt: Check rtotal instead of rbankable for both checkbox and button enable/disable logic Test plan: 1. Create transactions on a register using only Card payment type 2. Visit the register page - verify "Record cashup" button is enabled 3. Visit the registers page - verify the register checkbox is enabled and "Record cashup" button is enabled 4. Perform a cashup - verify it completes successfully Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.