https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21289 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78309|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 79380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79380&action=edit Bug 21289: Fix "isa" bug during partner request We cannot call 'handle_commit_maybe' inside a 'try' block. handle_commit_maybe redirects the client then calls 'exit', this is interpreted as an error and the 'catch' block is erroneously called. This patch moves the calling of 'handle_commit_maybe' outside the try block, it will only be reached if everything inside the try block suceeds. To test: 1) Enable ILL and have the FreeForm backend available 2) Create a patron category to hold ILL "partners" to whom requests can be sent. The category can be called anything, you should note the code you assign 3) Create a patron that belongs to your new category, the patron must have a primary email defined. 4) In your <interlibrary_loans> block in koha-conf.xml, ensure you have a <partner_code> element, it should contain the code you assigned in step 2 5) Create an ILL request using the FreeForm backend 6) Once the request is created, select the "Place request with partners" button 7) Select your "partner" from the "Select partner libraries" box 8) Click "Send email" 9) TEST: Observe no errors are displayed in the UI Signed-off-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.