https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35370 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 211774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211774&action=edit Bug 35370: Add ability to check out items on hold for someone else without a confirmation in the staff interface Some libraries would like the patron with the item in hand to always be able to check it out. Currently the staff interface always asks for confirmation when the item could fill another patron's hold, even if that hold is only pending and the library will always give the item to the patron at the desk. AllowItemsOnHoldCheckoutSIP and AllowItemsOnHoldCheckoutSCO already do this for SIP and the web based self checkout, but there is nothing like it for the staff interface. This patch makes the new system preference AllowItemsOnHoldCheckoutStaff work, with the same three levels as the SIP and SCO preferences: * Always ask for confirmation ( default, same as before ) * Don't ask for confirmation for pending holds * Don't ask for confirmation for pending or waiting holds A pending hold for the other patron is left as it is. A hold that is already waiting, in transit or in processing has that status reverted, the same as the default choice when staff are asked to confirm the checkout, so the hold isn't left waiting for an item that is checked out to someone else. If AllowHoldCheckoutOverride is set to "Don't allow", holds that still need a confirmation are blocked as before. Things to note: * Staff without the force_checkout permission can't confirm a checkout of an item on hold for someone else. A checkout that skips the confirmation doesn't need that permission. This is only a change if the new system preference is set to skip confirmations. * A "Cancel hold" remembered for the patron's session is *not* used for a hold that skips the confirmation, as staff were never asked. * Renewing an item that is on hold still asks for confirmation, so the renewal due date can still be set. * The hold confirmation that was skipped is still listed in the confirmations of the issue log entry, like it is for SIP. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Place a hold for patron A on a record with a single available item 5) Check the item out to patron B 6) Note the "has been on hold for" confirmation, click "No, don't check out" 7) Set AllowItemsOnHoldCheckoutStaff to "don't ask for confirmation for pending holds" 8) Check the item out to patron B again 9) Note the item is checked out with no confirmation! 10) Note patron A's hold is still pending! 11) Check the item in and confirm the hold for patron A 12) Check the item out to patron B again 13) Note you are still asked to confirm, click "No, don't check out" 14) Set AllowItemsOnHoldCheckoutStaff to "don't ask for confirmation for pending or waiting holds" 15) Check the item out to patron B again 16) Note the item is checked out with no confirmation! 17) Note patron A's hold is no longer waiting, it has been reverted to pending! 18) Check the item in and confirm the hold for patron A 19) Set AllowItemsOnHoldCheckoutStaff to "don't ask for confirmation for pending holds" and AllowHoldCheckoutOverride to "Don't allow" 20) Check the item out to patron B again 21) Note the checkout is blocked because the hold is waiting! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.