[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 --- Comment #24 from Oliver Bock <oliver.bock@aei.mpg.de> --- Warning: I just looked at the patch and didn't apply it. I think you lack a "$passwd_ok = 1" after checkpw_internal was called as a LDAP-fallback. IOW, the login attempt counter would be increased despite successful internal login after a LDAP bind error. Also: - is the "unless ( $passwd_ok ) {" ever closed? - the "} elsif ( $patron ) {" doesn't seem to have a parent if-clause Other than that your patch seems fine to me. -- You are receiving this mail because: You are watching all bug changes.