http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8458 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |INVALID --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- perlcritic does not report this as a PBP violation. Running perlcritic on C4/Search.pm in master results in: C4/Search.pm source OK PBP does recommend using my $string = q{}; instead of my $string = ""; or my $string = ''; but does not make a judgement on my $string; I believe this rule applies to re-initializing a previously used variable to an empty string, no initializing it to begin with. -- You are receiving this mail because: You are watching all bug changes.