https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43638 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Andrew, thanks, and sorry for the empty commit messages: the patches had no description or test plan at all. I've re-attached all seven with a description each, and the full test plan is in comment 13 (the 'Add patron_image_imports.pl cron job' patch); the Tools page and crontab patches have short ones of their own. What the bug does: it adds scheduled, unattended import of patron photos. You set up one or more accounts under Tools > Schedule patron image imports (a file transport to poll, and the field to match patrons on: card number, username or a unique patron attribute), and a new cron job, misc/cronjobs/patron_image_imports.pl, picks up new zip archives and loose images from that transport and imports them with the engine from Bug 43637. Each file is then moved to a processed or error directory and logged once per account and file name, so the job is safe to run repeatedly. I ran the whole plan from scratch in KTD to make sure it works as written: a loose image and a zip of two images are imported (3 patrons get a photo), a file matching no patron goes to error/ with PATRON_NOT_FOUND, a test run (no -c) changes nothing, re-dropping an already processed file name is reported as 'Already processed' and left alone, and deleting the account removes its log rows but keeps the imported photos. The new tests (Image/Import.t, the two object classes and the cron job's own test, 22 tests) pass. Two things you'll want to know when testing: - The Administration > File transports form only offers FTP and SFTP, so unless you have such a server to hand the plan creates a 'local' transport with one SQL insert (there's a ready-made Koha::File::Transport::Local the cron job supports). - The Tools page has no view of the log: the outcome is in the cron job's -v output and the patron_image_import_log table. The patches are also rebased on current main (bug 43637's are needed first), and the schema update is regenerated with dbic --force, since a change to FileTransport.pm in main had made the generated footer stale. Setting the status back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.