https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43895 Bug ID: 43895 Summary: Bug 42627 improvements and follow-ups Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- RM non-blocking feedback on Bug 42627: Not blockers as this is staged for push, but a few opportunities for follow-ups: 1) Open http://localhost:8081/cgi-bin/koha/labels/label-edit-range.pl 2) Enter 'Starting barcode' 000123 and 'Number of barcodes to print' 3, then click 'Print range' 3) Pick any template and layout, and click 'Export' 4) The legend reads 'Barcodes from 000123 to 125'. The batch already carries 'to' (txt_to), but label-print.tt:132 still computes from + count - 1. Using batche.to there would show 000123 to 000125 - barcode_length is now dead in label-print.tt: the PDF link param (line 136) and the hidden input (line 176) are always empty, and label-create-pdf.pl derives the length from 'from' anyway - Still curious about the 'else' -> 'elsif ($batch_id)' change in label-create-pdf.pl, was that intended? - Nits: the get_barcode_range POD shows positional args but it takes a hashref, and label-print.pl now has two 'use C4::Creators::Lib' lines Filing as a separate bug so this doesn't get lost in shuffle. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.