http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #3)
Comment on attachment 38954 [details] [review] Bug 14167 - Add Koha::Logger based on Log4perl
Review of attachment 38954 [details] [review]: -----------------------------------------------------------------
::: Koha/Logger.pm @@ +58,5 @@
+ my ( $class, $category ) = @_; + + croak("No category passed in!") unless $category; + + my $interface = C4::Context->interface();
What if it isn't set?
The idea is that we want the category to be required. That is absolutely no reason to log a line without specifying a category. -- You are receiving this mail because: You are watching all bug changes.