https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I think, ideally, this is what we'd do: 1) Update ILLModuleCopyrightClearance handling to be a ILL:Workflow stage like TypeDisclaimer or Availability, see bug 33716. The difference between CopyrightClearance and the other 2 is that CopyrightClearance only shows up in the OPAC and comes up before the create form, whereas the other 2 show up after the create form. I wanted to do this in bug 33716 but was out of scope for that specific bug. 2) sub backend_create should not handle ILLModuleCopyrightClearance directly, but instead have something like Koha::Illrequest::Workflow::CopyrightClearance->show_copyrightclearance and have that class do all the HTML customization logic handling. (In reply to Owen Leonard from comment #1)
sub backend_create { my ( $self, $params ) = @_;
# Establish whether we need to do a generic copyright clearance. if ( $params->{opac} ) {
my $copyright_content = Koha::AdditionalContents->search_for_display( { category => 'html_customizations', location => ['ILLModuleCopyrightClearance'], lang => $params->{lang}, library_id => $params->{branchcode}, } );
if ( ( !$params->{stage} || $params->{stage} eq 'init' ) && $copyright_content->count ) { ...
Is this a terrible idea?
I think this works, but I'm not familiar with HTML customizations enough to see possible issues this may open. What happens if more than one HTML customization exists for 'ILLModuleCopyrightClearance' location? -- You are receiving this mail because: You are watching all bug changes.