https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #70 from Nick Clemens <nick@bywatersolutions.com> --- Hi Ere, Thank you! Great refactoring! A few things: 1 - Generally we assume that we should index unless passed 'skip_record_index', rather than hardcoding not to 2 - If you change 'move_to_biblio' to take that param and allow the store to index otherwise then we can can remove MoveItemFromBiblio and simply use move_to_biblio in moveitem.pl 3 - please add a test to t/db_dependent/Koha/SearchEngine/Indexer.t to cover when indexing happens (or doesn't) for these subroutines (to prove the adopt method only calls once) -- You are receiving this mail because: You are watching all bug changes.