https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28528 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #7 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Marcel de Rooy from comment #6)
Moving to In Discussion. If you pass -fk and we are still going to delete, this may be confusing?
If someone calls the script with -fk, we assume that they are aware of the consequences and know what they are doing. As far as I remember, -fk appeared in this script when we introduced foreign keys on a larger scale, and execution with just -d became impossible in some cases (e.g., existing issues). We have two problems here, both solved with this patch: 1. Calling with -d, without -fk (when there are no dependencies blocking the deletion of records) causes the biblio_metadata table to be empty, but AUTO_INCREMENT in biblio_metadata remains set to the old value and increments differently than biblionumber (which is not a big technical problem, but will raise unnecessary questions or doubts). 2. Calling with -d and -fk causes biblio_metadata to retain rows that are not related to the biblio and biblioitems tables, which probably makes no sense. This is also not a technical problem, but it is a problem nonetheless, because this data takes up space completely unnecessarily and creates inconsistency in the data. -- You are receiving this mail because: You are watching all bug changes.