http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7597 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Ian Walls <koha.sekjal@gmail.com> 2012-03-01 20:20:49 UTC --- Part 1: just changes which field is recorded in writeoff from amount to amountoutstanding Part 2: moves code out of pay.pl and into C4/Accounts, which is very good. Unfortunately, the new subroutine, WriteOff, does not meet coding guideline PERL9... we've got the verb, but not the noun. WriteOffFee or WriteOffFine would be appropriate substitutions. Part 3: correspondingly fixes amount to amountoutstanding in writeoffall. Parts 1 and 3 pass QA, but part 2 does not. It's a small change to make, though, and once the WriteOff subroutine is renamed to follow PERL9, it will pass QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.