https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40294 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #59 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Issue on the upgrade path: 1) Start KTD without the patches, then apply them and run: updatedatabase 2) Edit the MEMBERSHIP_RENEWED notice: http://localhost:8081/cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=members&code=MEMBERSHIP_RENEWED 3) Expand the 'Print' section 4) Note the enrollment fee line has a literal '\n' in it, compare with the 'Email' section which has real line breaks Minor but worth correcting: - The atomicupdate output says 'MEMBERSHIP_RENEWAL' instead of 'MEMBERSHIP_RENEWED' - In t/db_dependent/Koha/Patrons.t, lines 3384 and 3386 check for existing phone/sms MEMBERSHIP_RENEWED templates, but lines 3393 and 3408 create MEMBERSHIP_EXPIRY ones, so the check and the create don't match -- You are receiving this mail because: You are watching all bug changes.