https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101615&action=edit Bug 24185: Make holds page faster: preparatory refactoring This is just refactoring. extracting logically independent code to separate sub + tests update. No logic change yet. Searching for "any_available" item among all biblionumber items was done inside of "elsif on_shelf_holds == 2", and it is logically very independent piece of code (this "@items" loop), it needs just biblionumber and patron as parameters so it can be extracted into separate subroutine, and later also called/reused from somewhere else. This ability to call from another place also made for future patch to remove O(n^2) problem with nested loops. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch, I moved up the last line of the test, sounds more logical to me. -- You are receiving this mail because: You are watching all bug changes.