https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38842 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | Keywords| |RM_priority CC| |paul.derscheid@lmscloud.de --- Comment #28 from Paul Derscheid <paul.derscheid@lmscloud.de> --- This is a big leap for modals in Koha, the implementation of the wrapper is great, maybe still needs refinement in some places but not worth not PQAing this right now :) I was starting to write a cypress test which would be nice but don't know how to do the syspref assertions. That probably requires selenium (ugh). Just went over the test plan again after perusing the files and this does everything it says it does and is even a UI improvement compared to the previous iteration. Great job Emily! Some things I still crave: - Similar documentation with one simple and one complex example following the style of the other bootstrap component wrappers in html_helpers.inc. Would be important for quickly using this wrapper to refactor, I think. - Would be great if we had some kind of test in place to make sure we do not introduce regressions in later versions. -- You are receiving this mail because: You are watching all bug changes.