https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85755|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89163&action=edit Bug 22420: Remove wrong calculation on approved tags Before the patch from bug 14385, the passed structure (that is returned by get_approval_rows() looks like: \ [ [0] { approved 1, approved_by 51, approved_by_name undef, date_approved "2019-02-26 15:36:42", term "another", weight_total 3 }, [1] { ... After the introduced 'filtering', we loose the information about the term weight!: \ [ [0] { approved 1, author "Heylin, Clinton.", biblionumber 1, borrowernumber 51, date_created "2019-02-26 15:36:37", language undef, subtitle [], tag_id 1, term "word", time_created_display "15:36:37", title "E Street shuffle :", visible 1, XSLTBloc " <<<BUNCH OF GENERATED HTML HERE>>> ... The code even calls GetMarcBiblio. This needs to be reverted as it is plain wrong. If it was worth removing *some* biblios from the weight_total value, then this calculation should be done somewhere else, without fetching the MARC data again. Signed-off-by: Claudio <costalc@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.