http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #7)
Some first notes on this:
I tested adding modifying and deleting cities and the display of the the cities list. All works well. but 3 requests, most important first:
1) Unit tests please!
I am not sure they are useful in this case. The tests for Koha::Object[s] already cover this area. But they cannot hurt :)
2) Should the copyright line be updated/amended in cities.pl? # Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN
3) A suggestion for the error messages: use 'adding' instead of 'inserting' - as that fits with the terminology in Koha a bit better.
Done. -- You are receiving this mail because: You are watching all bug changes.