https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 63477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63477&action=edit Bug 18434: Add tests for K:SE:E::get_fixer_rules This patch tries to introduce exhaustive tests for this class method. I didn't try to provide a regression test for the current bug per-se, but cover the current method behaviour as much as I could. (kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here and illuminate what the change does, before the patches this should fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended). A minor bug is highlighted by this new tests, I'll provide a followup for it. To test: - Run: $ sudo koha-shell kohadev k$ de kohaclone k$ prove t/db_dependent/Koha_Elasticsearch.t => FAIL: The returned fixer rules are not the expected ones Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.