https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Small code review: +my $datelastseen = $input->param('datelastseen') || $input->param('setdate'); We should not do that. It will disrupt some workflows. Datelastseen is the inventory date. - my $dls = output_pref( { dt => dt_from_string( $datelastseen ), - dateformat => 'iso' } ); +1 for removing those two lines :) I am removing this whole block on bug 14399. It is weird code. - if (none { $item->{barcode} eq $_->{barcode} && !$_->{'onloan'} } @$wrongplacelist) { + if (none { $_->{barcode} && $item->{barcode} eq $_->{barcode} && !$_->{'onloan'} } @$wrongplacelist) { Looks like rescuable lines to me now. - ModDateLastSeen($item->{'itemnumber'}); + ModItem({ itemlost => 0, datelastseen => $dls }, undef, $item->{'itemnumber'}); I understand why you do it. But I guess we might need a checkbox for that ? -- You are receiving this mail because: You are watching all bug changes.