https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44026 Bug ID: 44026 Summary: Bulk cover image upload dies with an error page when no line of the zip works, and the delimiter hint names the wrong character Initiative type: --- Sponsorship --- status: Product: Koha Version: 26.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: babarjunaid1122@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- In Tools > Upload local cover image (ZIP file), two problems in stable releases: 1. Uploading (a) a file that is not a zip, or (b) a zip whose datalink.txt has no valid line (e.g. "6 cover-6.jpg", no comma) fails with an error page (HTTP 500) instead of showing the UZIPFAIL / DELERR message. The log shows: Can't call method "biblionumber" on an undefined value at tools/upload-cover-image.pl line 256. A bulk upload has no itemnumber, so Koha::Items->find($itemnumber)->biblionumber dies when no line set a biblionumber. 2. The DELERR message says "Please verify that you are using either a single quote or a tab", but the script only accepts a comma or a tab (its own log message says "either a ',' or a 'tab'"). In main, bug 42804 removes this code (it replaces upload-cover-image.pl with the REST API), so these patches are for the stable branches: written against 26.05.x, and they apply cleanly to 25.11.x too. Reproduced on Koha 26.05.02. See also bug 37978, a different 500 on the same page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.