http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #39 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-19 15:07:38 UTC --- Paul, Okay, all QA comments dealt with but one:
This patch also changes the output of IsMemberBlocked, from returning the number of days they patron is blocked to the date they're blocked until. This means that issuingimpossible{USERBLOCKEDREMAINING} in C4::Circulation::CanBookBeIssued is populated with a date instead of an integer, breaking the display circ/circulation.tt (<li>Patron has had overdue items and is blocked for [% USERBLOCKEDREMAINING %] day(s).</li>). A simple change to circ/circulation.tt to handle this date correctly would suffice. This would introduce string changes.
The faulty string in question is on circ/circulation.tt, around line 390. Change it to "<li>Patron has had overdue items, and is blocked until [% USERBLOCKEDREMAINING %]</li>" would be sufficient. Since this is just a minor template only language issue (the key data is being presented, just not in a correct sentence), I don't think it's worth holding up the QA on this any more. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.