https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, giving this a go: 1) QA Tools fail: FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column itemtypes.rentalcharge_daily_calendar is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Itemtype.pm), see the SQL12 coding guideline The new column itemtypes.rentalcharge_hourly_calendar is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Itemtype.pm), see the SQL12 coding guideline 2) Usability I am a bit worried about usability: Say: finescalender is set to ignore holidays. And on the itemtype I check: Daily rentals use calendar But, if I understand correctly, they won't - because it falls back to finescalendar which is set to ignore holidays. This seems potentially confusing to me, as you can't see what finescalendar is set to and you have to read the 'fine print' (hint) and look it up to determine the actual behaviour. Instead, maybe we could label it: Use finescalendar setting. If not checked, holidays will be excluded when calculating rental charges. (please feel free to rephrase!) We could also include the value of finescalendar somewhere in the template maybe? Alternatively... should we remove the dependeny on finescalendar and make just the itemtype setting relevant? then we could just have: - ignore calendar - exclude holidays And it would be immediately visible from the item type configuration page, what rule will apply. -- You are receiving this mail because: You are watching all bug changes.