https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42298 Bug ID: 42298 Summary: "No automatic renewal before" falls back to "No renewal before" if former is greater than the latter Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Although this discovery was made due to a misconfiguration (we actually meant "no automatic renewals before" to have a value smaller than "no renewal before"), I think this finding is still worth reporting. --- Koha has two circulation rules for setting the earliest date a checkout can be renewed: "No renewal before" for manual renewals, and "No automatic renewal before" for automatic renewals. Using automatic renewals, we discovered that if circulation rule "No automatic renewal before" has a value greater than "No renewal before", automatic renewals are actually performed according to the "No renewal before" (manual) rule. Furthermore, this causes another bug where "too_soon" gets written in issues.auto_renew_error, instead of "auto_too_soon" as should be expected when called from the automatic_renewals.pl cronjob. This incorrect error status then causes yet another issue in AUTO_RENEWAL_DGST notices. The default notice template skips autorenewals with "auto_too_soon" error status, but since this bug writes it as "too_soon", the error is unhandled and such failed autorenewals unexpectedly become included in the notice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.