https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39287 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Hi Jan, Anke, Katrin, I have picked this up, as part of the work on how volumes and components are found with UseControlNumber (bug 34482). I have re-attached your two patches with my sign-off (the subject of Anke's patch, which was the pasted test plan, is now "Bug 39287: (follow-up) Add the rcn-volumes Elasticsearch mapping"), and attached two QA follow-ups on top of them. The Zebra part works well. With a set and volumes linked through 773, 800, 810 and 830, the old rcn search also found records linked as other edition, other format, predecessor and successor (8 records), and rcn-volumes finds only the 4 volumes. What I found and fixed: - The Elasticsearch mapping only had 773 and 830, so volumes linked through 800, 810 or 811 were missing with Elasticsearch only. It now maps the same fields as Zebra, and a test checks that the two stay in line. - The OPAC Show volumes link still searched rcn, while whether to show it is decided with the new index, so I changed it too. - rcn-volumes is added to getIndexes in C4::Search so that it is recognised as a CCL query with Zebra, as was done for cni. - t/db_dependent/Koha/Biblio.t failed because of the new index, so I updated it. - Existing Elasticsearch installations only get new fields when the mappings are reset, so there is a new atomic update, as for other fields. Zebra installations need to copy bib1.att, ccl.properties and biblio-zebra-indexdefs.xsl to their configuration and reindex, and Elasticsearch installations need a reindex, so this needs a release note. I checked it on Zebra and on Elasticsearch 8 with a set record, volumes linked through 773, 800, 810 and 830, and records linked through 775, 776, 780 and 785: both engines now return the same 4 volumes. Tests and the QA script pass. I am setting this to Signed Off so that it can go to QA. -- You are receiving this mail because: You are watching all bug changes.