https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39869 Bug ID: 39869 Summary: Club holds API missing tests Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org The introduction of `Test::NoWarnings` (bug 38944) allowed us to detect these tests do not cover all the behavior: when the database makes `Can*BeReserved` not return `status => OK` the tests pass (because the endpoint is designed to place the hold regardless, but a warning is printed in the logs. This behavior is not tested. The tests should: * Cover the item-level holds case * Not depend on existing data/circulation rules on the DB * Tests this `warn` behavior correctly -- You are receiving this mail because: You are watching all bug changes.