[Koha-bugs] [Bug 16088] Excessive CGI->new() calls hurting cache performace under plack

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jacek Ablewicz from comment #18)

That part of the code

if ( $cgi and not $cgi->param('language') ) { my $cached = $memory_cache->get_from_cache($cache_key);

still doesn't look quite right IMO; getlanguage() is almost never called with $cgi parameter, and the cached value will be hardly ever used.

Shoudn't it be something like that instead:

unless ($cgi && $cgi->param('language')) {

Indeed! -- You are receiving this mail because: You are watching all bug changes.