https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #13 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Martin Renvoize from comment #12)
Minor QA comments.
Hi Martin, I'll reply your comments
* We appear to load the verovio css regardless of the syspref settings
Yes, I didn't notice that one
* I think we seem to load the midi player JS even if we're only interested in displaying the musical notation (this might be me just not understanding the way the library code works)
No, midi player JS is wrapped by an IF statement [% IF playMusicalInscripts %] [% Asset.js("lib/verovio/000_acoustic_grand_piano.js") | $raw %] [% Asset.js("lib/verovio/midiplayer.js") | $raw %] [% END %]
* The clips seem to play very quickly to me.. I'm no musician though so perhaps they're playing at the proper speed?
I really don't know.. the midi player library has no options to control playing speed
* I'm sure how the $u subfield is intended to work.. you suggest in the test plan that it is required for this feature.. or is that simply to prove that $u still displays correctly when the verovio incipit are in place?
$u subfield it's really not related to the musical inscripts.. if it's not set, you simply don't get a link. I tought that it was very little effort to add a link if someone defined a url to the audio file Regarding your previous comment, I'll change the preferences to use ' Koha.Preference(' Thanks -- You are receiving this mail because: You are watching all bug changes.