https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #15)
I'm not seeing great unit tests for the branchlimits handling of the pickup_locations method
Tests added
As this fixes a bug I think we should write the tests to prove branchlimits side and probably go with the code as is.. however, as I dug into it, the code feels a bit manic in this area I feel like a bit of golfing down the line would be great.
I'd love to see the methods that are currently returning arrayrefs of Koha::Objects actually return proper Koha::Object sets which could then be chained properly.
I agree strongly, but would like to see this on a new bug, and happy to help on that front. This bug is a major issue and causing severe problems for our larger consortia and I would love to see it move forward -- You are receiving this mail because: You are watching all bug changes.